SQIL and PC performance check fixes #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestum
force-pushed
the
squil_performance_check_fixes
branch
from
b1b1f13
to
1b20336
Compare
ernestum
changed the title
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 95.67% 95.63% -0.05%
==========================================
Files 100 100
Lines 9581 9582 +1
==========================================
- Hits 9167 9164 -3
- Misses 414 418 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @AdamGleave would you review and merge? The coverage went down since I disabled the SQIL performance tests for now. |
AdamGleave
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
LGTM. Sorry for the slow review. If I'm blocking something feel free to either ping me or get someone else to review (can start asking @dan-pandori for example).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #807
Fixes #791
Testing
Changes are covered by the existing tests.